Ticket #4035 (closed Bug: fixed)

Opened 5 years ago

Collapsible fieldsets take up too much space

Reported by: limi Owned by:
Priority: major Milestone: 2.1
Component: Javascript Keywords:
Cc:

Description

Collapsible fieldsets should not have content inside, just be a single line with the [+] on it.

Change History

Changed 5 years ago by Anonymous User

working on this (bugday)

Changed 5 years ago by Anonymous User

actually, I was the one working on this, not an "anonymous user".

My solution isn't very good though. an empty fieldset looks silly

+-[+] legend --+ | | +--------------+

so I did some css/javascript trickery to get what I thought limi wanted:

--[+] legend ---

with a line the same color as the legend box. except there are still some positioning errors which seem really hard to resolve. half a mind to just throw that all away and just have a plain legend.

Changed 5 years ago by fschulze

This looks nice now, but sadly has some problems:

  • the horizontal line when collapsed is not visible in IE
  • I can reliably crash opera by double clicking on the +/- sign

We talked about it and I will try to implement it with different markup and another approach on the javascript side. Basically I will replace the fieldset with a dl and only toggle the styling, without touching the DOM.

Changed 5 years ago by optilude

  • status changed from new to closed
  • resolution set to fixed

Fixed by the unflinching Mr. fschulze

Note: See TracTickets for help on using tickets.