Ticket #3906 (closed Bug: fixed)

Opened 7 years ago

Last modified 3 years ago

incorrect mousepointer while moving over head of sortable list

Reported by: anneschneider Owned by:
Priority: trivial Milestone: 2.1
Component: Templates/CSS Version:
Severity: Keywords:
Cc:

Description

Hi,

when you want a list (any kind) to be sorted by a special feature (date, title, etc.) and move the pointer of your mouse over the head of the list, the pointer switches to the text insert mode instead of the link mode. This is not intuitive. Although after a click the sorting order changes.

Change History

comment:1 Changed 7 years ago by optilude

Limi will fix.

comment:2 Changed 7 years ago by hannosch

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in SVN (or Plone 2.1 RC).

comment:3 Changed 7 years ago by limi

  • Status changed from closed to new
  • Resolution fixed deleted

Not all lists are sortable, and it's wrong to show the pointer cursor on a list that is not.

The correct approach is to let the Javascript handle this by setting that property on the table header if sortability applies.

comment:4 Changed 7 years ago by hannosch

Sorry. I was under the impression that all tables with class set to 'listing' are sortable.

The following patch should be better:

Index: skins/plone_ecmascript/table_sorter.js =================================================================== --- skins/plone_ecmascript/table_sorter.js (revision 7694) +++ skins/plone_ecmascript/table_sorter.js (working copy) @@ -153,6 +153,7 @@

check that the columns does not have class="nosort" if (!xre.exec(node.className)) {

node.insertBefore(blankarrow.cloneNode(1), node.firstChild);

+ node.style.cursor = 'pointer';

if (!initialsort) {

initialsort = true; uparrow = document.createElement('img');

comment:5 Changed 7 years ago by limi

  • Status changed from new to closed
  • Resolution set to fixed

Excellent, thanks.

Committed to SVN.

comment:6 Changed 3 years ago by hannosch

  • Component changed from Visual and templates to Templates/CSS
Note: See TracTickets for help on using tickets.