Ticket #4145 (closed Bug: fixed)

Opened 7 years ago

Last modified 3 years ago

ID's on <div class="visualClear">

Reported by: spliter Owned by: spliter
Priority: minor Milestone: 2.5.1
Component: Templates/CSS Keywords: newbie
Cc:

Description (last modified by alecm) (diff)

It would be nice to have ID's on clearing elements like <div class="visualClear">. They can be useful in customization especially the ones in main_template (between portal_top and columns and before footer), but it's almost impossible to style them differently without template's cutomization.

Attachments

svndiff4145paregorius.txt Download (5.7 KB) - added by paregorius 6 years ago.
ids added on all <div class="visualClear"> not inside an element with tal:repeat

Change History

comment:1 Changed 6 years ago by alecm

  • Keywords newbie added
  • Owner changed from to limi
  • Description modified (diff)

We can probably use the unique-item iterator for this, or add relevant ids manually, if this is useful.

comment:2 Changed 6 years ago by alecm

  • Owner changed from limi to spliter

comment:3 Changed 6 years ago by alecm

  • Milestone changed from 2.5 to 2.5.x

comment:4 Changed 6 years ago by alecm

  • Keywords css added

comment:5 Changed 6 years ago by alecm

  • Keywords css removed

comment:6 Changed 6 years ago by pupq

Definitely add them manually, alecm; autonumbering them would be a mess--as soon as we added one, your CSS would break, as the numbers for all of them would shift. Better to give them names, id="clear-space-before-logo", etc.

comment:7 Changed 6 years ago by pupq

  • Milestone changed from 2.5.x to 2.5.1

Changed 6 years ago by paregorius

ids added on all <div class="visualClear"> not inside an element with tal:repeat

comment:8 Changed 6 years ago by alecm

  • Status changed from new to closed
  • Resolution set to fixed

(In [10368]) Applied patch from paregorius to add ids to all visualClear divs. Fixes #4145

comment:9 Changed 3 years ago by hannosch

  • Component changed from Visual and templates to Templates/CSS
Note: See TracTickets for help on using tickets.