Ticket #5056 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

Updated tableless main_template.pt

Reported by: claytron Owned by:
Priority: major Milestone: 2.1.3
Component: Templates/CSS Version:
Keywords: main template tableless newbie Cc:

Description (last modified by wichert) (diff)

I volunteered myself to update the tableless main_template.pt since it is missing a few things. Things that have been changed or added:

  • added id #portal-header
  • changed conditions on slots to use sl/sr from global_defines
  • changed footer and colophon macro calls
  • added metal:block around footer and colophon with i18n:domain
  • changed all html comments to <tal:comment replace="nothing">

Attachments

main_template.patch Download (13.2 KB) - added by claytron 6 years ago.
the patch file for use on the tableless main_template in trunk
main_template.pt Download (8.5 KB) - added by claytron 6 years ago.
the new tableless main_template.pt
main_template_4space.patch Download (18.2 KB) - added by claytron 6 years ago.
new file with 4 space tabs
main_template_4space.pt Download (10.0 KB) - added by claytron 6 years ago.
new file with 4 space tabs
main_template_4space_correct.patch Download (17.0 KB) - added by claytron 6 years ago.
oops, uploaded the wrong patch last time. this is the one for real
main_template.pt.patch.latest Download (17.0 KB) - added by claytron 6 years ago.
This is the latest patch. There were only two space tabs in the portal-top.

Change History

Changed 6 years ago by claytron

the patch file for use on the tableless main_template in trunk

Changed 6 years ago by claytron

the new tableless main_template.pt

comment:1 Changed 6 years ago by anonymous

changed to 4 space tabs as this is the Plone standard

Changed 6 years ago by claytron

new file with 4 space tabs

Changed 6 years ago by claytron

new file with 4 space tabs

Changed 6 years ago by claytron

oops, uploaded the wrong patch last time. this is the one for real

Changed 6 years ago by claytron

This is the latest patch. There were only two space tabs in the portal-top.

comment:3 Changed 6 years ago by claytron

Has anyone looked at this (besides big booty spammers)? I'd like to get these changes into the next release if at all possible.

comment:4 Changed 6 years ago by hannosch

  • Keywords newbie added

comment:5 Changed 6 years ago by wichert

  • Description modified (diff)

comment:6 Changed 6 years ago by hannosch

  • Milestone changed from 2.5.x to 2.1.3

comment:7 Changed 6 years ago by hannosch

  • Status changed from new to closed
  • Resolution set to fixed

(In [9709]) Updated tableless main_template.pt to get it in sync with the tablebased main_template.pt. This closes #5056.

comment:8 Changed 3 years ago by hannosch

  • Component changed from Visual and templates to Templates/CSS
Note: See TracTickets for help on using tickets.