Ticket #5078 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

Incorrect Coloring / CSS of Workflow States in Content Menu

Reported by: sirgarr Owned by: hannosch
Priority: minor Milestone: 2.1.3
Component: Templates/CSS Keywords:
Cc:

Description

In global_contentmenu.pt, the color of the workflow state is determined by the following:

tal:attributes="class string:state-${review_state}"

However, this is incosistent with how other templates define the class by first normalizing the review state:

tal:define="item_wf_state_class python:'state-' + here.plone_utils.normalizeString(item_wf_state);"

tal:attributes="class item_wf_state_class"

As a result, workflow states with spaces in their names do not display with the correct style. The code should be changed to something like the above.

Change History

comment:1 Changed 6 years ago by hannosch

  • Owner changed from somebody to hannosch
  • Milestone changed from 2.5.x to 2.1.x

comment:2 Changed 6 years ago by hannosch

  • Status changed from new to closed
  • Resolution set to fixed

(In [9705]) Fixed incorrect coloring of workflow states in content menu in some cases, due to missing normalizeString call. This fixes #5078.

comment:3 Changed 6 years ago by hannosch

  • Milestone changed from 2.1.x to 2.1.3

comment:4 Changed 3 years ago by hannosch

  • Component changed from Visual and templates to Templates/CSS
Note: See TracTickets for help on using tickets.