Ticket #5161 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

extra space in changeSiteActions function in \Data\Products\CMFPlone\migrations\v2_\betas.py

Reported by: P. Erickson Owned by:
Priority: major Milestone: 2.1.3
Component: Templates/CSS Keywords: newbie
Cc:

Description

In the function changeSiteActions(portal, out) in \Data\Products\CMFPlone\migrations\v2_\betas.py there is an extra space after "string:" lines # 981, # 988, # 995

This causes invalid html in site_actions after migrating. The rendered code (currently on the plone.org home page):

<li id="siteaction-accessibility"><a

href="  http://plone.org/accessibility-info" accesskey="0" title="Accessibility">Accessibility</a></li>

Notice the extra space between href=" and the URI.

This seems to happen in several files. If you search for "string: " (notice the trailing space) inside \Products\CMFPlone\, I find 33 files that have "string: ".

Change History

comment:1 Changed 6 years ago by jok2

  • Status changed from new to closed
  • Resolution set to invalid

According to  http://www.w3.org/TR/xhtml1/#h-4.7 and  http://www.w3.org/TR/REC-xml/#AVNormalize, leading and trailing space in attributes MUST be discarded by the xhtml parser. So <a href="  http://plone.org/accessibility-info"">accessibility/a> is valid xhtml.

comment:2 Changed 6 years ago by limi

  • Status changed from closed to reopened
  • Resolution invalid deleted

Yup; should still be fixed, though. :)

comment:3 Changed 6 years ago by hannosch

  • Keywords newbie added

comment:4 Changed 6 years ago by hannosch

  • Milestone changed from 2.5.x to 2.1.x

comment:5 Changed 6 years ago by hannosch

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [9754]) Fixed extra space in changeSiteActions function in some migrations. This closes #5161.

comment:6 Changed 6 years ago by hannosch

  • Milestone changed from 2.1.x to 2.1.3

comment:7 Changed 3 years ago by hannosch

  • Component changed from Visual and templates to Templates/CSS
Note: See TracTickets for help on using tickets.