Ticket #5299 (closed Feature Request: fixed)

Opened 6 years ago

Last modified 6 years ago

RTL Fixes & Hacks : sitemap / personaltools / folder listing / wide page

Reported by: smoothify Owned by:
Priority: major Milestone: 2.1.3
Component: RTL Keywords:
Cc:

Description

I've attached a modified version of RTL.css containing several fixes and due to the RTL bugs in the browsers a few hacks. There is also one minor change to global_personaltools.pt (adding a wrapper div to the #global-personaltools <ul>)

The sitemap issues were quite simple - just added some missing declarations in the generated part of RTL.css and reversed the borders for the sub levels from left to right.

I greatly improved the wide page issue by setting an explicit width for #portal-logo. It still shows a horizontal scroll bar but only for an extra pixel or two (couldn't find why that is still there)

The personal tools bar looks good now too due to some workarounds for the RTL bugs, (setting display:table)

Lastly there is also fixes to the folder listings page again using the display setting.

Attachments

RTL.css.dtml Download (10.1 KB) - added by smoothify 6 years ago.
RTL.css
global_personalbar.pt Download (1.6 KB) - added by smoothify 6 years ago.
global_personaltools

Change History

Changed 6 years ago by smoothify

RTL.css

Changed 6 years ago by smoothify

global_personaltools

comment:1 Changed 6 years ago by limi

  • Priority changed from minor to major
  • Milestone changed from 2.1.x to 2.1.3

Excellent - thanks!

I'll make sure this makes it into 2.1.3.

comment:2 Changed 6 years ago by smoothify

I've fixed the 1 pixel too wide page (causing a horizontal scrollbar) on both firefox and IE with a little hack.

You need to add the following to RTL.css

#portal-top{
    margin-right : 1px;
}

 http://rtl.smoothify.net/

comment:3 Changed 6 years ago by fschulze

  • Status changed from new to closed
  • Resolution set to fixed

(In [9351]) Incorporated various fixes for RTL support. fixes #5299

Note: See TracTickets for help on using tickets.