last_login_time incorrect?

[jan.murre@…]

In CMFPLone.MembershipTool.MembershipTool.setLoginTimes() there is:

    def setLoginTimes(self):
        """ Called by logged_in to set the login time properties
            even if members lack the "Set own properties" permission.
        """
        if not self.isAnonymousUser():
            member = self.getAuthenticatedMember()
            login_time = member.getProperty('login_time', '2000/01/01')
            if  str(login_time) == '2000/01/01':
                login_time = self.ZopeTime()
            member.setProperties(login_time=login_time,
                                 last_login_time=self.ZopeTime())

So last_login_time is set to the current time. After you have logged in, this property is useless to get the content that has been updated after the previous login.

I think it should be:

            member.setProperties(login_time=self.ZopeTime(),
                                 last_login_time=login_time)

[wichert]

(In [10258]) Fix handling of login_time and last_login member properties. fixes #5471

[hannosch]

(In [10784]) Adjusted test for initial log-in time to new behaviour introduced in rev10258. Refs #5471.