Ticket #5496 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

Bug in login_success

Reported by: mtiller Owned by: plonista
Priority: minor Milestone: 2.1.3
Component: Infrastructure Keywords:
Cc:

Description

In Plone 2.1.2 I found a problem with the "login_success" template. If you "came_from" somewhere else (as indicated by the presence of the "came_from" argument) then things are OK. But if you didn't, the code looks like this:

<p tal:condition="python:not came_from">

<a href=""

tal:attributes="href came_from" i18n:translate="label_login_continue_to_home_page">

Continue to the <span tal:content="portal/title" i18n:name="portal_title">

portal title

</span> home page </a>

</p>

Obviously, if came_from isn't set then the href value does not make sense. I simply changed this to:

<a href=""

tal:attributes="href portal_url" i18n:translate="label_login_continue_to_home_page">

and it works fine.

Change History

comment:1 Changed 6 years ago by hannosch

  • Milestone changed from 2.5.x to 2.1.x

comment:2 Changed 6 years ago by hannosch

  • Status changed from new to closed
  • Resolution set to fixed

(In [9745]) Fixed bug in login_success. If you did not came_from somewhere, it would still offer you to go there. Changed this to portal_url instead. This closes #5496.

comment:3 Changed 6 years ago by hannosch

  • Milestone changed from 2.1.x to 2.1.3

comment:4 Changed 3 years ago by hannosch

  • Component changed from Login and registration to Infrastructure
Note: See TracTickets for help on using tickets.