Ticket #5521 (closed Feature Request: fixed)

Opened 6 years ago

Last modified 3 years ago

CSS and Javascript ResourceRegistry improvement

Reported by: wald Owned by: dunlapm
Priority: major Milestone: 3.3
Component: Infrastructure Keywords:
Cc: interra

Description (last modified by dunlapm) (diff)

  • It would be nice to be able to register external css and javascripts. Currently we can add local staff only and we need to customize main_template to add external css or javascript. Proposal: add 'external' Render Type This is now ticket #8312.
  • Currently IEFixes.css is included in mail_template after all css defined in portal_css tool. It means that we can't change it's highest priority. It would be good to have the ability to include IEFixes.css by registering it with portal_css tool.

Proposal: add 'ie-include' Render Type

Attachments

registries.patch Download (21.7 KB) - added by dunlapm 4 years ago.
Proposed patch for registries

Change History

comment:1 Changed 6 years ago by hannosch

  • Owner changed from somebody to fschulze
  • Priority changed from minor to major
  • Milestone changed from Future to 2.5

comment:2 Changed 6 years ago by interra

  • Description modified (diff)

I've changed proposed by wald CSS 'include' into 'ie-include'.

ie-include would require exta field, 'IE version' as existing ones does not represent the semantics properly.

comment:3 Changed 6 years ago by alecm

  • Milestone changed from 2.5 to 2.5.x

This is not a bugfix, so it shouldn't be filed under 2.5.0

comment:4 Changed 6 years ago by pupq

The external CSS/JS is a particularly nice idea, I think. We'd just have to help people understand that it wouldn't be merged/cached/etc like the other stuff, but I like it.

comment:5 Changed 6 years ago by limi

  • Milestone changed from 2.5.x to 3.0

comment:6 Changed 5 years ago by elvix

+1 for adding support for external

comment:7 Changed 5 years ago by wichert

  • Milestone changed from 3.0 to 3.5

comment:8 Changed 4 years ago by hannosch

  • Type changed from enhancement to Enhancement
  • Milestone changed from 4.0 to Future

comment:9 Changed 4 years ago by dunlapm

  • Status changed from new to assigned
  • Owner changed from fschulze to dunlapm

Work started on conditional comments (for IE) in  http://svn.plone.org/svn/plone/ResourceRegistries/branches/dunlapm-conditional-comments/

comment:10 Changed 4 years ago by dunlapm

  • Description modified (diff)

Changed 4 years ago by dunlapm

Proposed patch for registries

comment:11 Changed 3 years ago by dunlapm

  • Milestone changed from Future to 3.3

comment:12 Changed 3 years ago by fschulze

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [24245]) Merged 'dunlapm-conditional-comments' branch. Simplified template changes. Added test case. Fixes #5521

Note: See TracTickets for help on using tickets.