Ticket #5526 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

ATTopic's queryCatalog ignores the b_size parameter

Reported by: bader Owned by: alecm
Priority: critical Milestone: 2.1.4
Component: Infrastructure Keywords: attopic, batch
Cc:

Description

in ATContentTypes/content/topic.py:

     460         # Batch based on limit size if b_szie is unspecified
     461         if max_items and b_size is None:
     462             b_size = int(max_items)
     463         else:
     464             b_size = 20

should be:

     460         # Batch based on limit size if b_size is unspecified
     461         if max_items and b_size is None:
     462             b_size = int(max_items)
     463         else:
     464             b_size = b_size or 20

Explanations: the queryCatalog prototype:

queryCatalog(self, REQUEST=None, batch=False, b_size=None, full_objects=False, **kw)

takes b_size as parameter. But if b_size is different from None b_size value will be erased by 20 ! (line 464)

By the way

# Batch based on limit size if b_szie is unspecified

should be replaced by:

# Batch based on limit size if b_size is unspecified

(b_size in place of b_szie)

Change History

comment:1 Changed 6 years ago by alecm

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in ATCT svn -r24028, thanks Bader!

comment:2 Changed 5 years ago by hannosch

  • Milestone changed from 2.1.x to 2.1.4

comment:3 Changed 3 years ago by hannosch

  • Component changed from Content Types to Infrastructure
Note: See TracTickets for help on using tickets.