Ticket #5569 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

Links in folder_contents to non-folderish content wrong

Reported by: jbaldivieso Owned by: alecm
Priority: critical Milestone: 2.5.1
Component: Templates/CSS Keywords: folder_contents
Cc:

Description

It looks like the fix to #4407 went a little too far -- now all urls in the content listing in folder_contents end in /folder_contents. That means, for instance, that the folder contents for the root of a brand new OOTB plone site will contain a link to front-page/folder_contents. Very confusing to users to see their Pages seemingly turn into empty folders.

Change History

comment:1 Changed 6 years ago by jbaldivieso

Further examination shows that it's not folder_contents' fault; it looks like isStructuralFolder is returning false positives, and lots of them.

A temporary solution can be found by reverting to pre-view syntax; in line 196 of folder_contents.pt change:

item_folderish item/@@plone/isStructuralFolder|item/isPrincipiaFolderish|nothing

to:

item_folderish item/is_folderish|item/isPrincipiaFolderish|nothing

comment:2 Changed 6 years ago by alecm

  • Priority changed from major to critical
  • Owner changed from limi to alecm
  • Milestone changed from 2.5.x to 2.5.1

comment:3 Changed 6 years ago by alecm

Hm, I cannot reproduce. My front page does not get folder_contents appended.

comment:4 Changed 6 years ago by alecm

Additionally, my folder_contents contains no references to isStructuralFolder

comment:5 Changed 6 years ago by alecm

  • Status changed from new to closed
  • Resolution set to fixed

(In [10364]) Made is_folderish and isStructuralFolder respect the z2 INonStructuralFolder interface as well as the z3 one. This fixes #5569 and #5592. Also, added a migration to reindex the catalog, which is needed for #5569 and #5231.

comment:6 Changed 3 years ago by hannosch

  • Component changed from Usability to Templates/CSS
Note: See TracTickets for help on using tickets.