plone.css breaks upgrades

[wichert]

If you upgrade a site which has plone.css enabled in portal_css the site will no longer work after the upgrade. The traceback:

2006-07-01 14:26:47 ERROR Zope.SiteErrorLog http://localhost:8080/racleiden/port
al_css/plone.css/index_html
Traceback (innermost last):
  Module ZPublisher.Publish, line 106, in publish
  Module ZPublisher.BaseRequest, line 476, in traverse
  Module ZPublisher.BaseRequest, line 511, in exec_callables
  Module Products.ResourceRegistries.tools.BaseRegistry, line 205, in deferredGe
tContent
  Module Products.ResourceRegistries.tools.BaseRegistry, line 169, in __getitem_
_
  Module Products.ResourceRegistries.tools.BaseRegistry, line 469, in getResourc
eContent
  Module Products.CMFCore.FSPythonScript, line 108, in __call__
  Module Shared.DC.Scripts.Bindings, line 311, in __call__
  Module Shared.DC.Scripts.Bindings, line 348, in _bindAndExec
  Module Products.CMFCore.FSPythonScript, line 164, in _exec
TypeError: plone.css() takes no arguments (2 given)
2006-07-01 14:26:47 ERROR root Exception while rendering an error message

The cause is that plone.css has suddenly changed from a dtml template to a python script.

[maurits]

As another data point: I see this too in my event.log. I don't notice any adverse effects though. At least the site is still working. Maybe my site (well, from a customer, using the plone 2.1 svn branch) is too heavily customized and that's why I do not notice. I don't quite know what problems to look for actually.

Disabling plone.css in the portal_css indeed stops this error and I don't immediately notice any display problems after that.

[alecm]

This isn't a newbie issue, wonder why I put that there. So I have the same behavior as Maurits, I get the error in my log, but no effect on site rendering, strange. plone.css is deprecated, no? It should be spitting out a warning when used on it's own, and there should be a migration to remove it from portal_css because it is redundant. However, should we also be tweaking rr so that it can render python scripts? There are likely some usecases for this, though this is certainly not one of them, and in this case if it worked, we'd probably get infinite recursion.

[alecm]

Fixed in r10356 by adding a migration and deprecating the script

[alecm]

(In [10358]) That should have been fixes #5614 :-(

[limi]

Uhm, plone.css is NOT deprecated. The problem here is that plone.css was in the RR, which it shouldn't be.

plone.css.py is for use when you need to get one single file that contains the CSS of your Plone site *for use from external tools* - think planet.plone.org, Trac, etc.

[alecm]

OK, that bit is easy enough to undo, will do so monday.

[alecm]

done

[maurits]

It seems fixed for Plone 2.5 now. But Plone 2.1 from the branch still has that problem. Can the migration step be backported to 2.1? The bug was never in an official release, but still. I have the bug on the site of a customer. I can remove plone.css from the portal_css by hand of course, but probably more people see this problem, so having this migration step available for 2.1 as well would be nice.

[alecm]

(In [10413]) Backport change from 2.5 which fixes #5614