Ticket #5695 (closed Bug: fixed)

Opened 6 years ago

Last modified 3 years ago

Incorrect message after bad login attempt

Reported by: treaves Owned by: hannosch
Priority: minor Milestone: 2.5.1
Component: Infrastructure Keywords: newbie
Cc:

Description

1) Type username/incorrect password into box in left slot. 2) The login page displays, with the username filled in and the password black, with a message about invalid login. 3) enter correct password into password field and click login. 4) The resulting page shows 'You are now logged in', but immeadiatly above it is the orage error box stating 'Login Failed'.

Attachments

plone5695.txt Download (25.3 KB) - added by cschaba 6 years ago.
some Live HTTP Headers

Change History

comment:1 Changed 6 years ago by alecm

  • Keywords newbie added
  • Milestone changed from 2.5.x to 2.5.1

comment:2 Changed 6 years ago by cschaba

It seems that the display of the "LOGIN_FAILED_MESSAGE" comes one request too late. I think the login_form call in the *next* Request the login_form_validate which sets the cookie and then Displays the form, but at this time without the message. The message is displayed on the next page, successfull login or not.

Maybe a redirect to login_form can solve the problem...

Changed 6 years ago by cschaba

some Live HTTP Headers

comment:3 Changed 6 years ago by hannosch

  • Owner changed from plonista to hannosch

I should probably look into this, thx cschaba for the details :)

comment:4 Changed 6 years ago by cschaba

maybe this solves the problem:

found in PloneTool.py Line 713:

"It is also possible to add messages from page templates, as long as they are processed before the portal_message macro is called by the main template...."

comment:5 Changed 6 years ago by hannosch

(In [10381]) Extended LoginAndLogout tests, refs #5695.

comment:6 Changed 6 years ago by hannosch

  • Status changed from new to closed
  • Resolution set to fixed

(In [10382]) Fixed incorrect status message after bad login attempt. This closes #5695.

comment:7 Changed 3 years ago by hannosch

  • Component changed from Login and registration to Infrastructure
Note: See TracTickets for help on using tickets.