Ticket #5904 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Plone 2.5 does not allow to change skins

Reported by: aiste Owned by: wichert
Priority: critical Milestone: 2.5.3
Component: Infrastructure Keywords:
Cc:

Description

Users cannot change the plone skin, though that preference is enabled and visible in the user preferences page.

When a user goes there and changes the skin, clicks on save, he gets the following messages after the page reloads:

'You have been registered.' 'Your personal settings have been saved.'

But the skin is back to the default.

I can change the skin globally, i.e. through Site setup. The only user that can change the skin through the user preferences page is the one that is defined through zcml.

It's a plone 2.5.1 instance, on zope 2.9.3, python 2.4.3 running on Gentoo.

Change History

comment:1 Changed 5 years ago by limi

  • Component changed from Unknown to Infrastructure

Either we should fix this, or remove the option for skins-per-user.

comment:2 Changed 5 years ago by alecm

  • Owner changed from somebody to wichert

This must be due to some PAS related changes assigning to wiggy (sorry). Can somebody verify this?

comment:3 Changed 5 years ago by alecm

This can almost certainly be fixed without too much work, but I can't do it for 2.5.2, wiggy?

comment:4 Changed 5 years ago by alecm

  • Priority changed from major to critical

comment:5 Changed 5 years ago by sirgarr

The culprit: updateSkinCookie in CMFCore's SkinTool tries to look up member.portal_skin instead of member.getProperty('portalSkin').

comment:6 Changed 5 years ago by sirgarr

Sorry, member.getProperty('portal_skin')

comment:7 Changed 5 years ago by limi

  • Milestone changed from 2.5.x to 2.5.3

Also something that should be easy to include in 2.5.3, I'd apply it, but I want somebody else to verify that it's sane.

comment:8 Changed 5 years ago by alecm

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in CMFCore r74143

Note: See TracTickets for help on using tickets.