Fix the Restrict Types page

[limi]

Current problems:

• People forget to check the "Override settings"

• The order of the two selection lists is opposite of what people expect

[limi]

Ideally, something like this:

   ( ) Use defaults
 __(o) Specify manually_________________________
|                                               |
| Types in the menu                             |
| [x] Page     [ ] Folder    [ ] News Item      |
| [x] Event    [ ] Image     [ ] Collection     |
| [ ] File     [ ] Link                         |
|                                               |
|                                               |
| Additional available types                    |
|  x Page      [x] Folder    [ ] News Item      |
|  x Event     [x] Image     [ ] Collection     |
| [ ] File     [x] Link                         |
|_______________________________________________|


 [Save] [Cancel]


Legend:

[o] Radio button
[ ] Empty checkbox
[x] Selected checkbox
 x  Ghosted checkbox

Ideally, the fieldset is ghosted when Use Defaults is selected, and unghosted when you select Specify Manually, but that's something we need to solve generally in Plone too. We need that pattern in a lot of other locations too.

[limi]

This might be useful (hiding the fieldset is also a way of doing it instead of ghosting):

 http://talk.quintagroup.com/blogs/myroslav/kss-opener/introduction

[jonthomas1986]

Attached two patches to fix the first portion of this bug. One patch modifies the test_constraintypes file to add an additional test and correct another. The second patch modifies code within constraintypes to cause the list of defaultAddableTypes to come back sorted.

[hannosch]

Sorting the values based on their title_or_id method doesn't make much sense. If we are to sort them, then we should sort them based on their translated title, to be consistent with the add-new-item dropdown.

[limi]

This is a good sprint task. :)

[ramonski]

A partial fix for this bug. Needs review.

[seletz]

Submitted further work on that one as r14090. UI is functional and usable, but maybe needs cleanup :)

[optilude]

See also #5323.

[seletz]

The javascript stuf is done. The checkboxes are greyed-out when clicking them is not allowed.

This IMHO has only plain HTML/CSS layout issues.

[limi]

OK, I have tested the new implementation a bit, and it's a bit too easy to make the JS do things that are confusing and/or wrong. Part of the fault here lies with me, since I didn't do a good enough job in reducing this form to be as simple as it can possibly be.

I have attached a form (*_redux) that looks correct layout- and text-wise — so use that as your starting point — but it needs some changes to the JS since I haven't touched that.

It probably needs changes to the backend code too. I'm not sure how these variables are stored internally, but you might have to invert or move things from one variable to another when handling the form on submit. (Remember that changing how it is stored is not an option, since people have existing settings that need to work here :)

I'll try to explain the new approach below:

   ( ) Use defaults
 __(o) Specify manually_________________________
|                                               |
| Allowed types                                 |
| [x] Page     [ ] Folder    [ ] News Item      |
| [x] Event    [x] Image     [ ] Collection     |
| [ ] File     [ ] Link                         |
|                                               |
|                                               |
| Secondary types                               |
| [ ] Page      ·  Folder     ·  News Item      |
| [ ] Event    [x] Image      ·  Collection     |
|  ·  File      ·  Link                         |
|_______________________________________________|


 [Save] [Cancel]


Legend:

[o] Radio button
[ ] Empty checkbox
[x] Selected checkbox
 ·  Ghosted checkbox (unselected)

So, as you can see, it's close, but much simpler:

• You first start with selecting what types should be allowed
• Any types that *are* allowed are selectable in the Secondary types section
• Any types that are *not* allowed have a ghosted checkbox in the Secondary types section
• Any types selected in Secondary types will show up on the "More" menu

The above form in its current state would result in:

• Page, Event, Image are all allowed in the folder
• Page and Event show up in the menu
• Image is available from the "More" menu

If you have time to look into this, I would be very grateful, and sorry for making the task so complex in the first place — I should have spent some more time thinking it through first.

[limi]

The much simplified version of the form ~limi

[seletz]

Starting to work on that again. I'll have a look at limis form.

[seletz]

Ok, this should be fixed now:

• the form now works as prototyped by limi here
• I added labels for the checkboxes
• The checkboxes now are displayed in three columns, like the search control panel.