Ticket #6705 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Inline editing doesn't work with AT view macros

Reported by: limi Owned by: limi
Priority: critical Milestone: 3.0.1
Component: KSS (Ajax) Keywords:
Cc:

Description (last modified by limi) (diff)

When using the Archetypes widgets in view mode, inline editing should work — currently it doesn't. This is super important to fix before 3.0 ships, as this is the only way we can let novice developers get inline editing on their products in an easy way.

Attached is a template that you can use to test if the inline editing is working on all fields that we need it for:

  1. Put document_view_test_inline somewhere in the skin path
  1. Create a Page, make sure you have filled in something in all the available fields.
  1. Call document_view_test_inline on it, and you will have a page that calls all the fields using the AT widget views.

Hope this makes it easier to test/fix what's remaining in the inline editing support for AT. I see that there are some widgets that have suboptimal default views, I'll look into that (for example, the categories view should list things as a bulleted list, right now I think it just inserts <br> tags). But I'll handle that part. :)

Attachments

document_view_test_inline.pt Download (1.9 KB) - added by limi 5 years ago.
Test template for inline editing

Change History

Changed 5 years ago by limi

Test template for inline editing

comment:1 Changed 5 years ago by limi

  • Description modified (diff)

comment:2 Changed 4 years ago by optilude

  • Priority changed from critical to major

Balazs and I took a look at this a few months ago. It's actually a surprisingly difficult problem to solve given the way that AT view macros are structured. Invoking the edit page is fine, but it becomes difficult to get the display mode back, as far as I recall.

There is a pattern now for getting inline editing in custom views. It's not perfect, but it's not impossible to understand either. I suspect this may have to do for now, until we can refactor the AT widgets machinery.

If someone can come up with a usable pattern, though, I'd be interested in helping to implement it.

comment:3 Changed 4 years ago by limi

  • Priority changed from major to critical
  • Milestone changed from 3.0 to 3.0.x

comment:4 Changed 4 years ago by limi

  • Owner changed from ree to limi

comment:5 Changed 4 years ago by limi

  • Status changed from new to closed
  • Resolution set to fixed

(In [17022]) Updating all the view templates to use AT widget "view" modes. This fixes #6705. Relies on the updates in r8500 in the AT repository to produce valid HTML.

Note: See TracTickets for help on using tickets.