plone.app.i18n.locales.languageselector does not show up in portal_view_customizations tool

[kteague]

The plone.app.customerize.templateViewRegistrations function decides what is available in the view customizations tool.

This can be fixed by changing the name of the class to end with the word 'Viewlet'. Although that could break existing add-ons and customizations. One could check for 'IViewlet.implementedBy(factory)' although maybe that brings in unwanted Viewlets? Or perhaps add a special case just for the LanguageSelector? Or finally 'fix it right' as suggested by the TODO ...

# TODO: this should really be dealt with using # a marker interface on the view factory

[hannosch]

Assigning to Mr. Customerize :)

[witsch]

(In [18327]) the name of customerizable viewlets should not have to end in "Viewlet" ?\226?\128?\148 they should also be picked up when implementing "IViewlet" (fixes #7408)

[witsch]

Replying to kteague:

This can be fixed by changing the name of the class to end with the word 'Viewlet'. Although that could break existing add-ons and customizations.

that would just be a (imho bad) workaround.

One could check for 'IViewlet.implementedBy(factory)' although maybe that brings in unwanted Viewlets?

nope, it doesn't — the diff of the registration info before and after r18327 is

regs

@@ -434 +434 @@
             {'customized': None,
              'for': 'zope.interface.Interface',
+             'type': 'plone.app.layout.viewlets.interfaces.IPortalTop',
+             'viewname': u'plone.app.i18n.locales.languageselector',
+             'zcmlfile': 'plone.app.i18n.locales.browser/configure.zcml',
+             'zptfile': 'plone.app.i18n.locales.browser/languageselector.pt'},
+            {'customized': None,
+             'for': 'zope.interface.Interface',
              'type': 'plone.app.layout.viewlets.interfaces.IBelowContentBody',
              'viewname': u'plone.belowcontentbody.workflowhistory',

so it only adds the language selector, but then again more missing viewlets would have been most welcome, of course... :)

Or finally 'fix it right' as suggested by the TODO ...

yes, it really should be done like this, but that has to wait a little longer. for 3.0.4 the quick fix from r18327 will have to do...

many thanks for reporting & also the hints on how to fix it, though. much appreciated! :)