Kupu full screen mode looks broken

[grahamperrin]

First noted whilst editing a PloneHelpCenter FAQ object in Plone 3.0.3.
Sorry, I can't recall whether that was before or after I updated Kupu there from 1.4.5 to 1.4.6. I made that  PloneHelpCenter issue 90 ...

... but later, I noted the same symptoms whilst editing a normal page object, and now I see the symptoms with a clean 3.0.4 installation.

See attached. Peculiar.

Regards
Graham

---

• Plone 3.0.4
• CMF-2.1.0
• Zope (Zope 2.10.5-final, python 2.4.4, darwin)
• Python 2.4.4 (#1, Dec 7 2007, 21:01:51) [GCC 4.0.1 (Apple Computer, Inc. build 5250)]
• PIL 1.1.6

[grahamperrin]

Issue is still evident in Plone 3.0.5 built from Plone-3.0.5-UnifiedInstaller on Mac OS X 10.4.11, Intel MacBook Pro.

[ivan]

this is a problem with the kupubasetools.js file. i made some changes to the kupu 1.4.7 version of kupubasetools.js to remove references to the unsupported (in firefox) getElementsByClassName function. it now looks like this and works fine:

KupuZoomTool.prototype.onresize = function() {
    if (!this.zoomed) return;

    var editor = this.editor;
    var iframe = editor.getDocument().editable;
    var sourcetool = editor.getTool('sourceedittool');
    var sourceArea = sourcetool?sourcetool.getSourceArea():null;
    var fulleditor = iframe.parentNode;

    if (window.innerWidth) {
        var width = window.innerWidth;
        var height = window.innerHeight;

//ivan removed these lines to make zoom button work
//        var tbheight = fulleditor.parentNode.getElementsByClassName('kupu-tb')[0].getHeight();
//        var nheight = height - tbheight + 'px';
//

    } else if (document.documentElement) {
        if (!window._IE_VERSION) {
            _IE_VERSION = /MSIE\s*([0-9.]*)/.exec(navigator.appVersion);
        };
        var kludge = (_IE_VERSION[1]<7)?5:0;
        var width = document.documentElement.offsetWidth-kludge;
        var height = document.documentElement.offsetHeight-kludge;
        var offset = fulleditor.offsetTop;
        var nheight = Math.max(height - offset -1/*top border*/, 10) + 'px';
    } else {
            var width = document.body.offsetWidth-5;
            var height = document.body.offsetHeight-5;
            var offset = fulleditor.offsetTop;
            var nheight = Math.max(height - offset -1/*top border*/, 10) + 'px';
        }
        width = width + 'px';
        // changes here by ivan to fix the full screen zoom bug
        var offset = iframe.parentNode.offsetTop;
        var nheight = Math.max(height - offset -1/*top border*/, 10) + 'px';
        //

        fulleditor.style.width = width; /*IE needs this*/
        iframe.style.width = width;
        iframe.style.height = nheight;
        if (sourceArea) {
            sourceArea.style.width = width;
            sourceArea.style.height = nheight;
        }
};

[elvix]

Changed title to clarify.

I can reproduce this issue. Although experienced users can safely ignore it, and keep using Kupu in half-fullscreen, it scares novices terribly.

[grahamperrin]

Thank you, people.

Please: will this fix, or something comparable, be present

• in Plone 3.1 on 2nd March

or

• in (maybe) version 1.4.8 of Kupu?

Just asking. Not pushing :)

[duncan]

Probably. I'll be going through the current issues sometime between now and kupu 1.4.8 release date.

[duncan]

Applied patch to kupu then tidied up the code to remove duplication. SVN revision 51159

[grahamperrin]

Duncan, you're a gentleman. Cheers!