Ticket #7768 (closed Bug: fixed)

Opened 4 years ago

Last modified 23 months ago

Dropdown menu of add portlet is not fully translated

Reported by: juh Owned by:
Priority: major Milestone: 3.3.5
Component: Infrastructure Keywords:
Cc:

Description

Some entries in the list of addable portlets are not translated.

Change History

comment:1 Changed 4 years ago by maurits

Indeed when I manually add these lines to the Dutch plone-nl.po translations show up:

msgid "Classic portlet"
msgstr "Klassieke portlet"

msgid "Calendar portlet"
msgstr "Kalenderportlet"

So those message ids (and those for a few other portlets) should end up in plone.pot. I suspect it is enough to add something 'i18n_domain="plone"' at the top of CMFPlone/profiles/default/portlets.xml and run i18ndude but my tries there failed to give results.

comment:2 Changed 4 years ago by hannosch

(In [19980]) Added missing i18n markup to portlets.xml file. This refs #7768.

comment:3 Changed 4 years ago by hannosch

  • Owner changed from hannosch to optilude
  • Component changed from Internationalization to Portlets
  • Milestone changed from 3.0.x to 3.1

I added tests for the missing i18n markup support for the portlets.xml files to plone.app.portlets in [19984].

Once the exportimport handler in p.a.portlets is fixed to use real Messages for the title and description attributes of PortletInfos, we can add the strings from all the portlets.xml files to plone.pot.

comment:4 Changed 4 years ago by optilude

What do you need from me here?

comment:5 Changed 4 years ago by hannosch

Sorry, if this wasn't clear. The exportimport code in plone.app.portlets needs to create Messages in the right domain on the persistent portlet type objects (p.a.p.exportimport.portlets._initPortletNode and _extractPortletNode) instead of simple text strings. The more tricky part is parsing and handing down of the i18n:domain from any upper node, but for now a restriction where one can only specify the domain on the portlets root node or the portlets node itself would work just fine.

I was under the impression, that someone added this exportimport code as part of Plone 3.1 and you might know who that someone is (I haven't followed the lists that closely in the last weeks).

comment:6 Changed 4 years ago by optilude

I wrote most of the GS code, and George Lee and Florian wrote the rest. Can you give an example of how to do this?

comment:7 Changed 4 years ago by hannosch

  • Milestone changed from 3.1 to 3.x

comment:8 Changed 4 years ago by optilude

  • Owner changed from optilude to hannosch

Hanno has code to fix this, and promised to look later.

The offending code is in plone.app.portlets.exportimport.portlets, in _initPortletNode(), where the portlet type's title and description are being set.

Martin

comment:9 Changed 4 years ago by hannosch

  • Milestone changed from 3.x to 3.3

This will need a change in the persistent data, not for 3.1.x

comment:10 Changed 3 years ago by hannosch

  • Owner hannosch deleted
  • Milestone changed from 3.3 to Future

comment:11 Changed 3 years ago by hannosch

  • Milestone changed from Future to 3.x

comment:12 Changed 3 years ago by hannosch

  • Component changed from Portlets to Infrastructure

comment:13 Changed 23 months ago by juh

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.