plone.app.contentmenu bad generated id (bad XML syntax)

[dmunicio]

There are some id attributes like "_advanced", "_folderChangeDefaultPage", etc. that are non XML syntax compliant (an id attribute should not start with and underscore).

You can see it easily with HTML Validator (Firefox plugin) when logged in Plone 3.0.6

I attach monkey patch. I could not find any feature that relies on these ids, so it seems to be safe.

Thanks

[dmunicio]

plone.app.contentmenu monkey patch

[limi]

I'll let the infrastructure people evaluate this.

[hannosch]

The monkey patch isn't very readable, but the ticket description is clear enough.

Eliminate all ids starting with an underscore and test that all behavior is still working fine (or grep for those ids in the codebase).

[garbas]

removed ids with underscore in front od them. grep for those ids if there apear somewhere else

[garbas]

open it to close it with commit

from #plone-tuneup: 21:04 < DigitalD> garbas: if you mention the ticket number in the form of (fixes #ticketnum) in your svn commit the tracker will automatically close the ticket

[garbas]

valid patches are:

• 31branch_plone.app.contentmenu_8195.patch
• 31branch_CMFPlone_fix_8195.patch

this is done for 3.1 branch (trunk comming in few minutes)

[garbas]

valid patches for plone trunk are:

• trunk_Products.CMFPlone_fix.patch
• trunk_plone.app.contentmenu_fix.patch

[calvinhp]

(In [22380]) Fix non XML syntax compliant ids in contentmenus. Closes #8195