Aliases for Content Types don't provide IViewView in case they refer to (Default)

[spliter]

If you create alias for Folder for example like:

index.html    (Default)

you would expect to get the same you get from "view" alias (unless it's aliased to the same (Default)). But right now this doesn't happen. Aliased view you get at your_folder/index.html doesn't provide IViewView that leads to missing contentActions ("Display", "Add new" and so on) on aliased view. Moreover if you have any other stuff, based on presence of IViewView (custom viewlet maybe?) you get it broken as well.

The problem is in plone.app.layout.globals.context - every entry we have for checking whether we are actually at the view have hardcoded "/view" url. This doesn't look nice. It should check whether the current view is the same as (Default) and not use hardcoded URLs.

[regebro]

This code fixes the issues we have, but maybe there is a better way:

in plone.app.layout.globals.context.ContextState:

def is_view_template(self): ...

elif current_url == object_url + '/view':

return True

+ context = aq_inner(self.context) + browserDefault = IBrowserDefault(context, None) + fti = browserDefault.getTypeInfo() + if current_url.split('/')[-1] in fti.getMethodAliases(): + return True

...

[regebro]

Sorry about that, trying again:

    def is_view_template(self): 
        ...
        elif current_url == object_url + '/view':
            return True

+        context = aq_inner(self.context)
+        browserDefault = IBrowserDefault(context, None)
+        fti = browserDefault.getTypeInfo() 
+        if current_url.split('/')[-1] in fti.getMethodAliases(): 
+           return True

[optilude]

Sorry, this has been stuck with me, but it's not something I'll have time to look into.

[maurits]

Replying to regebro:

Sorry about that, trying again:

    def is_view_template(self): 
        ...
        elif current_url == object_url + '/view':
            return True

+        context = aq_inner(self.context)
+        browserDefault = IBrowserDefault(context, None)
+        fti = browserDefault.getTypeInfo() 
+        if current_url.split('/')[-1] in fti.getMethodAliases(): 
+           return True

This would return True for all aliases, so also for 'edit' as alias for 'atct_edit' and we don't want that. This seems to do the trick instead:

if fti.getMethodAliases().get(last_part) == '(Default)':

return True

Looking at tests now, and meanwhile claiming the ticket before someone else grabs it on this TuneUp day.

[maurits]

Right, trying again as well, for better formatting.

Replying to regebro:

Sorry about that, trying again:

     def is_view_template(self): 
         ...
         elif current_url == object_url + '/view':
             return True
 
 +        context = aq_inner(self.context)
 +        browserDefault = IBrowserDefault(context, None)
 +        fti = browserDefault.getTypeInfo() 
 +        if current_url.split('/')[-1] in fti.getMethodAliases(): 
 +           return True
 

This would return True for all aliases, so also for 'edit' as alias for 'atct_edit' and we don't want that. This seems to do the trick instead:

        if fti.getMethodAliases().get(last_part) == '(Default)':
            return True

Looking at tests now, and meanwhile claiming the ticket before someone else grabs it on this TuneUp day.

[maurits]

(In [52327]) Slight refactoring of is_view_template for clarity. Refs #8198.

[maurits]

(In [52328]) Treat aliases to the '(Default)' view of a content type also as a view template (providing IViewView). Fixes #8198

[maurits]

(In [52331]) Merge r52327 and r52328 from trunk: Treat aliases to the '(Default)' view of a content type also as a view template (providing IViewView). Fixes #8198

[maurits]

(In [52342]) Fixed error introduced by previous commit r52328: AttributeError: 'NoneType' object has no attribute 'getTypeInfo'. Refs #8198

[maurits]

(In [52343]) Merged r52342 from trunk: Fixed error introduced by previous commit r52328: AttributeError: 'NoneType' object has no attribute 'getTypeInfo'. Refs #8198