Ticket #8468 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

User | Group Memberships | select then remove group | removal fails; site manager is silently misdirected to the wrong user

Reported by: grahamperrin Owned by: calvinhp
Priority: critical Milestone: 3.3
Component: Users/Groups Keywords: TuneUpSept26, blackbelt
Cc: ajgoesele, gabdavhp

Description

Actions

For a user (in this case an OpenID user):

  • open the Group Memberships tab
  • select (tick) a group
  • click Remove selected groups.

Bug aspect 1

Critically:

  • the removal does not occur

— and the site manager may remain unaware of the failure.

Bug aspect 2

Possibly less critically:

  • the User Properties tab to which the site manager is taken is for a user other than the one that was being managed.

I'll attach screen shots.

Environment

Plone 3.1.5.1

Attachments

selection prior to clicking 'Remove selected groups'.png Download (23.9 KB) - added by grahamperrin 3 years ago.
after clicking the button, the manager is silently taken to details for a different user.png Download (17.3 KB) - added by grahamperrin 3 years ago.
Group Memberships tab is without explanation focused on the wrong user
trunk_fix_8468.diff Download (580 bytes) - added by garbas 3 years ago.
31branch_fix_8468.diff Download (4.6 KB) - added by garbas 3 years ago.

Change History

Changed 3 years ago by grahamperrin

Changed 3 years ago by grahamperrin

Group Memberships tab is without explanation focused on the wrong user

comment:1 in reply to: ↑ description Changed 3 years ago by grahamperrin

I wrote:

the User Properties tab to which the site manager is taken

Correction; I meant, the Group Memberships tab.

comment:2 Changed 3 years ago by grahamperrin

Correction

Mis-coloured tabs led to that particular mistake, so we have a separate ticket:

comment:3 Changed 3 years ago by grahamperrin

Workaround

  1. focus on a group
  1. click the Group Members tab
  1. select the user that you wish to remove
  1. click Remove selected groups / users.

Whilst capturing that workaround I noted another separate issue:

comment:4 Changed 3 years ago by gabdavhp

  • Keywords TuneUpSept26 added

comment:5 Changed 3 years ago by grahamperrin

I'm tentatively cross referencing this ticket:8468 with another, more recent, roles and groups assigned to users can _not_ be removed. The symptoms in the latter are more critical in that rights granted can not be revoked.

comment:6 Changed 3 years ago by grahamperrin

Workaround involving ZMI

/acl_users/source_groups/manage_groups

For the bugged group, click the question mark under Assignments.

In the Active area, select the bugged user.

Click the left arrow, to move the user to the list of Available users at left hand side.

(Expected: a move from right to left. Instead: the user's name disappears completely, which is confusing, but that's probably a cosmetic bug in ZMI, not Plone.)

comment:7 Changed 3 years ago by ajgoesele

  • Cc ajgoesele added

Very same problem here on a fresh test install and on our production site. (3.1.5.1)

comment:8 Changed 3 years ago by grahamperrin

  • Cc gabdavhp added

Possible cross reference between this ticket:8468 and TTP view of group membership differs from ZMI view.

comment:9 Changed 3 years ago by gabdavhp

  • Keywords TuneUpSept26, blackbelt added; TuneUpSept26 removed

comment:10 Changed 3 years ago by garbas

  • Owner set to garbas

comment:11 Changed 3 years ago by garbas

  • Status changed from new to assigned

Changed 3 years ago by garbas

Changed 3 years ago by garbas

comment:12 Changed 3 years ago by garbas

this issue was 3.1 branch related. in trunk was already fixed but something else was missing so i fixed that to.

trunk_fix_8468.diff 31branch_fix_8468.diff

comment:13 Changed 3 years ago by garbas

  • Owner changed from garbas to calvinhp
  • Status changed from assigned to new

comment:14 Changed 3 years ago by calvinhp

(In [22681]) Fixed the silent fail of the group membership from a user, thanks to garbas, refs #8468

comment:15 Changed 3 years ago by calvinhp

(In [22682]) Fixed the missing tal define in prefs_user_memberships, thanks to garbas, refs #8468

comment:16 Changed 3 years ago by calvinhp

  • Status changed from new to closed
  • Resolution set to fixed

comment:17 Changed 3 years ago by hannosch

  • Milestone changed from 3.x to 3.3
Note: See TracTickets for help on using tickets.