Ticket #10882 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

[Collections] and/or operator makes absolutely no sense for criterion "Item type"

Reported by: kleist Owned by: msmith64
Priority: trivial Milestone: 4.1
Component: General Version:
Keywords: TuneUp blackbelt forcommit Cc: msmith64

Description

Plone 4 coredev buildout

After having added an "Item type" criterion for a collection, there is a radio button "Operator used to join the tests on each value." below the item type selection list. The buttons are labeled "and", "or".

Since an item has one and exactly one type, this operator has no function but to confuse the user. An item can simply not be a File and an Image.

Attachments

Clipboard01.png Download (14.1 KB) - added by kleist 5 years ago.
Products.ATContentTypes-no-operator-for-types.patch Download (619 bytes) - added by msmith64 4 years ago.
That was easier than I expected.

Change History

Changed 5 years ago by kleist

comment:1 Changed 4 years ago by jessilfp

  • Keywords TuneUp blackbelt added

comment:2 Changed 4 years ago by asigottech

Is this not both expected behavior and critical ? it is used to further define the criteria required such as Event AND 1 day - in the past OR Creator - admin for example, maybe change the language but do not remove the operator buttons as that cripples mutable criteria (or am I missing something here ?)

comment:3 follow-up: ↓ 4 Changed 4 years ago by asigottech

To re-iterate the above, "An item can simply not be a File and an Image." but it can be Image "and" created by

comment:4 in reply to: ↑ 3 Changed 4 years ago by msmith64

  • Cc msmith64 added

Replying to asigottech:

To re-iterate the above, "An item can simply not be a File and an Image." but it can be Image "and" created by

Right, but that's not what "operator name" actually seems to do (according to the empirical tests I just did). This operator applies to the values for the individual criterion and doesn't affect the relationship between criteria.

The portal_types criterion actually ignores the operator setting. It always "or"s the values, which is the only thing that makes sense. We just need to get rid of the form control.

Changed 4 years ago by msmith64

That was easier than I expected.

comment:5 Changed 4 years ago by msmith64

  • Keywords forcommit added

comment:6 Changed 4 years ago by msmith64

  • Status changed from new to assigned
  • Owner set to msmith64

comment:7 Changed 4 years ago by msmith64

  • Status changed from assigned to closed
  • Resolution set to fixed

In  231257 removed superfluous 'and/or' operator.

comment:8 Changed 3 years ago by davisagli

  • Component changed from Infrastructure to General
Note: See TracTickets for help on using tickets.