Ticket #13045 (closed Bug: fixed)

Opened 3 years ago

Last modified 2 years ago

Hardcoded workflow state in new byline code

Reported by: alecm Owned by: piv
Priority: minor Milestone: 4.3
Component: General Version: 4.3
Keywords: Cc: piv, esteele

Description

Though this was a known risk of this PLIP (#8699), it seems problematic. We don't really hardcode behavior based on specific workflow state names in Plone; I think for good reason. This feature should either use an admin selectable workflow state config, or ignore workflow state entirely and always show the effective data if available. The later solution would avoid the need to look at workflow internals as well, which is best avoided and creates a potential undesirable information leak (which will be described in another ticket).

See the related review:

 https://github.com/plone/buildout.coredev/blob/4.3/plips/reviews/plip8699-review-alecm.txt

Change History

comment:1 Changed 3 years ago by kleist

  • Status changed from new to confirmed

comment:2 Changed 3 years ago by alecm

  • Cc piv, esteele added

comment:3 Changed 2 years ago by piv

  • Status changed from confirmed to assigned
  • Owner set to piv

comment:4 Changed 2 years ago by piv

  • Status changed from assigned to closed
  • Resolution set to fixed

I picked easier option: always display effective date if it is set, regardless of object state:  https://github.com/plone/plone.app.layout/commit/e1d458735db77949650a42c578ffe1305e6fdafe

Note: See TracTickets for help on using tickets.