Ticket #5253 (closed Bug: fixed)

Opened 8 years ago

Last modified 4 years ago

Advanced search should not show duplicate states

Reported by: keul Owned by: witsch
Priority: minor Milestone: 4.0
Component: General Version:
Keywords: sprint Cc:

Description

In a Plone site with custom workflows, the advanced search form can create a non valid XHTML source because duplicate states id may appear.

This understood when differente workflow has the same state id but with different title, that Plone 2.1 use to label the checkbox.

eg: Base Plone workflow: 'private' --> 'Private' My workflow: 'private' --> 'Personal'

I think that will be better if: 1) workflow state checkbox appear once in the advanced_search list of states 2) The label of the check will be the merge of all possible state in a form like this:

[_] Visible [x] Private/Personal ...

Attachments

5253.patch Download (3.5 KB) - added by miziodel 7 years ago.
patch for workflow_tool and search_form

Change History

comment:1 Changed 7 years ago by limi

  • Keywords sprint added; search_form review_state removed
  • Summary changed from Advanced search may show duplicate id for review state to Advanced search should not show duplicate states

Yup, identical review state names on the Advanced Searc form should only be displayed once. Should be a simple sprint task. :)

comment:2 Changed 7 years ago by miziodel

working on it from Sorrento..

Changed 7 years ago by miziodel

patch for workflow_tool and search_form

comment:3 Changed 6 years ago by witsch

  • Owner changed from somebody to witsch

grabbing all tickets from "somebody" after having signed up as the "owner" of the "Catalog" and "Search" components... :)

comment:4 Changed 5 years ago by hannosch

  • Component changed from Search to Infrastructure

comment:5 Changed 4 years ago by esteele

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 3.x to 4.0

This should be corrected (and does for me after some quick testing) now that we're using plone.app.vocabularies to generate the states listing. Feel free to reopen if that's not the case.

comment:6 Changed 4 years ago by esteele

Boy, I can't communicate this evening... That should read "This should be fixed (and appears to be..."

comment:7 Changed 22 months ago by davisagli

  • Component changed from Infrastructure to General
Note: See TracTickets for help on using tickets.