Ticket #7253 (closed Bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Versioning broken for folderish content types

Reported by: forsberg Owned by: alecm
Priority: minor Milestone: 3.0.4
Component: Versioning Version:
Keywords: Cc:

Description

Versioning on folderish content types doesn't seem to work to 100%. Here's how to repeat some of the problems I've found:

  1. Enable versioning on Folder in @@types-controlpanel

  1. Create new folder. Save.
  1. Modify description of folder. Save.
  1. View history and compare working copy to previous revision. Changes are not listed - only the headers for Changed/Removed/Added files are listed.
  1. Add a Page to the folder.
  1. Again, view history of the folder and compare working copy to previous revision. Under "Changed Files", there is now a single bullet. The HTML generated looks like this:
   <ul>
        <li>
            
       </li>
    </ul>

Also, I would have expected the file to be shown under 'added files', not 'changed files'. How is added files supposed to work, btw - will there be a new revision of the Folder for each added file?

Change History

comment:1 Changed 6 years ago by forsberg

  • Plone 3.0.2
  • CMF-2.1.0
  • Zope (Zope 2.10.4-final, python 2.4.4, linux2)
  • Python 2.4.4 (#2, Apr 12 2007, 21:03:11) [GCC 4.1.2 (Ubuntu 4.1.2-0ubuntu4)]
  • PIL 1.1.6

comment:2 Changed 6 years ago by forsberg

Problem seems to go away if you add a diff type for the content type, in portal_diffs.

Perhaps this should be done for the Folder type?

comment:3 Changed 6 years ago by alecm

  • Status changed from new to closed
  • Resolution set to fixed

(In [18144]) Added folder type to diff tool, fixes #7253

comment:4 Changed 6 years ago by alecm

The type has been added to the diff tool. The UI bug that caused new files to appear in changes has been fixed. Files won't appear in any of those fields unless the "OMInsideRefsModifier' is enabled for those folders, so that the versioned folder contents are retrieved along with the folder.

Note: See TracTickets for help on using tickets.