Ticket #7740 (closed Feature Request: fixed)

Opened 6 years ago

Last modified 6 years ago

bundle review for PLIP #205

Reported by: witsch Owned by: mj
Priority: major Milestone: 3.1b1
Component: Unknown Version:
Keywords: review bundled Cc: sirgarr, optilude, mj

Description

the bundle for  PLIP #205: Flexibility Associating Portlet Types and Portlet Managers needs to be reviewed for potential inclusion in the upcoming  Plone 3.1 release.

Change History

comment:1 Changed 6 years ago by witsch

  • Type changed from Bug to Enhancement

comment:2 Changed 6 years ago by witsch

review bundle available at review/plip205-portlettypes-multiplemanagers along with notes regarding the review; afaics the review itself is still pending...

comment:3 Changed 6 years ago by witsch

  • Cc sirgarr, optilude added

comment:4 Changed 6 years ago by witsch

  • Keywords bundled added

comment:5 Changed 6 years ago by witsch

  • Status changed from new to assigned
  • Owner changed from somebody to witsch

comment:6 Changed 6 years ago by witsch

(In [19140]) added notes from first bundle review for PLIP #205 (see #7740)

comment:7 follow-up: ↓ 8 Changed 6 years ago by witsch

  • Status changed from assigned to new

this is finished from my side, but i'll keep it until the first round of reviews is complete...

comment:8 in reply to: ↑ 7 Changed 6 years ago by witsch

  • Owner changed from witsch to sirgarr

Replying to witsch:

this is finished from my side, but i'll keep it until the first round of reviews is complete...

ah, wrong! actually this should go to george, so that he can respond to the issues found in the review... :)

comment:9 follow-up: ↓ 10 Changed 6 years ago by witsch

  • Owner changed from sirgarr to witsch
  • Cc mj added

george updated the review notes in r19172 and made changes to the code in r19160:19164 and r19170:19171. cc'ing martijn as he's about to review this, too...

comment:10 in reply to: ↑ 9 Changed 6 years ago by witsch

  • Owner changed from witsch to mj

Replying to witsch:

george updated the review notes in r19172 and made changes to the code in r19160:19164 and r19170:19171. cc'ing martijn as he's about to review this, too...

these changes have addressed all the (mostly minor) issues i've found in my initial review, so there're none left anymore... :) thanks george!!

passing on to martijn for a second review...

comment:11 Changed 6 years ago by mj

My thumbs up for this plip can be found in r19322. :-)

comment:12 Changed 6 years ago by witsch

  • Status changed from new to closed
  • Resolution set to fixed

two reviews in, with no pending issues — excellent work, george!

comment:13 Changed 6 years ago by raphael

+1

Note: See TracTickets for help on using tickets.