Ticket #7990 (closed Bug: worksforme)

Opened 6 years ago

Last modified 6 years ago

Internal link drawer broken for editors

Reported by: dunny Owned by: duncan
Priority: major Milestone: 3.1.5
Component: Visual Editor Version:
Keywords: Cc:

Description

Using Plone 3.1-rc1, kupu 1.4.9. Try editing an existing page as an editor, not as a manager, and use the internal link drawer. The drawer never renders any links.

I think this is a simple permissions problem with getDefaultScaleForType(). See the attached patch against trunk.

(Also - while editing plonelibrarytool it looked like there were a couple of other accessors that might have the same problem with permission restrictions.)

Attachments

getDefaultScaleForType.diff Download (568 bytes) - added by dunny 6 years ago.

Change History

Changed 6 years ago by dunny

comment:1 Changed 6 years ago by dunny

Just noticed that this sounds similar to  http://www.nabble.com/Plone-3.0.6---Kupu-Bug----I-can-only-access-the-image-icon-in-cupu-as-manager%21-td16355032s6741.html

Which tells me that there is a specific permission that should be used rather than "View". So I tested with permissions.QueryLibraries and that works correctly too.

comment:2 Changed 6 years ago by duncan

  • Status changed from new to closed
  • Resolution set to fixed

I think you are correct, there seem to be a lot of accessors which currently require ManageLibraries permission when View should be sufficient. I've changed them (SVN revision 53093).

comment:3 Changed 6 years ago by hannosch

  • Milestone changed from 3.1 to 3.x

Milestone 3.1 deleted

comment:4 Changed 6 years ago by dguedry

  • Status changed from closed to reopened
  • Resolution fixed deleted

This seems to still be an issue in Plone 3.1.1 (w/ Kupu 1.4.9). Only managers can access the Insert Link and Insert Image dialogs in Kupu.

comment:5 Changed 6 years ago by dguedry

After posting previous comment, realized that if user or group were explicitly set to "Editor", all was well. This is a different behavior than in Plone 3.0.6

comment:6 Changed 6 years ago by hannosch

  • Milestone changed from 3.1 to 3.x

comment:7 Changed 6 years ago by davisagli

  • Status changed from reopened to closed
  • Resolution set to worksforme

Works for me in Plone 3.1 dev buildout with kupu 1.4.10.

Note: See TracTickets for help on using tickets.