Ticket #9415 (closed Bug: fixed)

Opened 5 years ago

Last modified 3 years ago

change the collection portlet template for rounded corners after the footer

Reported by: spereverde Owned by: msmith64
Priority: minor Milestone: Ongoing
Component: Templates/CSS Version:
Keywords: newbie Cc:

Description

currently the template of footer of the collection portlet looks like this:

    <dd class="portletFooter" tal:condition="view/data/show_more">
        <span class="portletBottomLeft"></span>
        <span>
        <a tal:attributes="href collection_url" i18n:translate="more_url">
             More&hellip;
             </a>
        </span>
        <span class="portletBottomRight"></span>
    </dd>

When you disable the 'Show more... link' option in the collection portlet settings, this will remove the entire portletFooter, including your spans for rounded corners (portletBottomLeft and portletBottomRight). I guess these spans should be moved outside of the portletFooter so the bottom of your portlet can still be layouted, even when you don't have a portletfooter.

Change History

comment:1 Changed 5 years ago by wichert

  • Keywords newbie added

comment:2 Changed 5 years ago by vincentfretin

I think we can move tal:condition="view/data/show_more" in the second span.

I think we have a similar problem with plone.portlet.static and news and rss portlets in plone.app.portlets.

comment:3 Changed 3 years ago by msmith64

I was planning to work on this, but instead just ended up writing functional test for plone.portlets.collection. Whoever gets around to this bug, *please* add functional tests for the case described here.

comment:4 Changed 3 years ago by msmith64

  • Status changed from new to assigned
  • Owner set to msmith64
  • Milestone changed from 3.3.x to Ongoing

 Changeset 50011 demonstrates this bug.

comment:5 Changed 3 years ago by msmith64

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in  changeset 50012.

Note: See TracTickets for help on using tickets.